Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests #1885

Merged
merged 4 commits into from
Mar 5, 2021
Merged

More tests #1885

merged 4 commits into from
Mar 5, 2021

Conversation

na--
Copy link
Member

@na-- na-- commented Mar 5, 2021

This should close #1873 and adds the missing test from #1882. This can also be considered a somewhat tentative first step in #342

@na-- na-- added this to the v0.31.0 milestone Mar 5, 2021
@na-- na-- force-pushed the more-tests branch 2 times, most recently from c0a046b to 30704a3 Compare March 5, 2021 14:01
@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #1885 (30704a3) into master (1721868) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
+ Coverage   71.12%   71.22%   +0.09%     
==========================================
  Files         183      183              
  Lines       14319    14319              
==========================================
+ Hits        10185    10198      +13     
+ Misses       3506     3495      -11     
+ Partials      628      626       -2     
Flag Coverage Δ
ubuntu 71.16% <ø> (+0.07%) ⬆️
windows 70.79% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
output/json/json.go 84.48% <ø> (ø)
js/runner.go 81.44% <0.00%> (+0.57%) ⬆️
output/cloud/output.go 80.62% <0.00%> (+1.83%) ⬆️
core/engine.go 87.50% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1721868...2cfbf46. Read the comment docs.

@na-- na-- changed the title [WIP] More tests More tests Mar 5, 2021
@na-- na-- requested review from imiric and mstoykov March 5, 2021 14:06
mstoykov
mstoykov previously approved these changes Mar 5, 2021
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe move the test extensions in the samples ?

.github/workflows/xk6.yml Outdated Show resolved Hide resolved
@na--
Copy link
Member Author

na-- commented Mar 5, 2021

I thought about samples, but these extensions aren't a good example for potential extension authors... so I'd prefer it is very clear that they are for testing purposes only

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

And we want to run this on every commit, right? I suppose it's fine, and it runs quick enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI task for checking xk6 compatibility
4 participants