-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More tests #1885
More tests #1885
Conversation
c0a046b
to
30704a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1885 +/- ##
==========================================
+ Coverage 71.12% 71.22% +0.09%
==========================================
Files 183 183
Lines 14319 14319
==========================================
+ Hits 10185 10198 +13
+ Misses 3506 3495 -11
+ Partials 628 626 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe move the test extensions in the samples
?
I thought about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
And we want to run this on every commit, right? I suppose it's fine, and it runs quick enough.
This should close #1873 and adds the missing test from #1882. This can also be considered a somewhat tentative first step in #342