Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic on binaryResponses where the body wasn't set #2041

Merged
merged 1 commit into from
May 25, 2021

Conversation

mstoykov
Copy link
Collaborator

This panic was still caught and didn't abort the whole k6 just the
current iteration.

This panic was still caught and didn't abort the whole k6 just the
current iteration.
@mstoykov mstoykov requested review from imiric and na-- May 25, 2021 08:30
@mstoykov mstoykov added this to the v0.33.0 milestone May 25, 2021
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #2041 (9b8cde2) into master (5fe5e5a) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2041      +/-   ##
==========================================
- Coverage   71.75%   71.67%   -0.09%     
==========================================
  Files         179      177       -2     
  Lines       14104    14099       -5     
==========================================
- Hits        10121    10106      -15     
- Misses       3345     3352       +7     
- Partials      638      641       +3     
Flag Coverage Δ
ubuntu 71.67% <100.00%> (-0.03%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/modules/k6/http/response.go 78.57% <100.00%> (ø)
js/common/initenv.go 66.66% <0.00%> (-33.34%) ⬇️
lib/testutils/minirunner/minirunner.go 76.08% <0.00%> (-4.35%) ⬇️
lib/netext/httpext/error_codes.go 94.52% <0.00%> (-2.74%) ⬇️
js/initcontext.go 90.42% <0.00%> (-2.13%) ⬇️
lib/executor/vu_handle.go 93.33% <0.00%> (-0.96%) ⬇️
js/runner.go 81.30% <0.00%> (-0.57%) ⬇️
cmd/ui_windows.go
lib/netext/httpext/error_codes_syscall_windows.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe5e5a...9b8cde2. Read the comment docs.

@mstoykov
Copy link
Collaborator Author

The test failures should be fixed by #2038

@mstoykov mstoykov merged commit 5602c42 into master May 25, 2021
@mstoykov mstoykov deleted the preventPanicOnStatus0BinaryResponse branch May 25, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants