Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency in env variables names #2140

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Fix inconsistency in env variables names #2140

merged 2 commits into from
Oct 4, 2021

Conversation

yorugac
Copy link
Contributor

@yorugac yorugac commented Sep 17, 2021

Very small fix 🙂

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yorugac yorugac requested a review from a team September 17, 2021 14:03
codebien
codebien previously approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imiric
imiric previously approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised nobody has mentioned this before 😅 We should probably mark it as a breaking change in the release notes.

@imiric imiric added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Sep 17, 2021
na--
na-- previously approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though please also add a test in https://github.com/grafana/k6/blob/master/cmd/config_consolidation_test.go
Our config is woefully under-tested, so we might as well start with simple things like this.

@yorugac yorugac dismissed stale reviews from na--, imiric, and codebien via d82f159 September 27, 2021 07:49
@yorugac yorugac requested review from a team, codebien and imiric October 1, 2021 12:07
@yorugac yorugac merged commit 586f0e5 into master Oct 4, 2021
@yorugac yorugac deleted the fix-env-vars-names branch October 4, 2021 08:51
@na-- na-- added this to the v0.35.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebien codebien codebien approved these changes

@imiric imiric imiric approved these changes

@mstoykov mstoykov mstoykov approved these changes

@na-- na-- na-- left review comments

Assignees
No one assigned
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Milestone
v0.35.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yorugac @CLAassistant @mstoykov @imiric @codebien @na--