Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the very old and unused errors metric #2164

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Remove the very old and unused errors metric #2164

merged 1 commit into from
Oct 7, 2021

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Oct 7, 2021

No description provided.

@mstoykov mstoykov added this to the v0.35.0 milestone Oct 7, 2021
inancgumus
inancgumus reviewed Oct 7, 2021
View reviewed changes
Copy link
Member

@inancgumus inancgumus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't remove this comment, please ignore this.

inancgumus
inancgumus requested changes Oct 7, 2021
View reviewed changes
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't you suppose to remove this as well?

ErrorsName            = "errors"

k6/lib/metrics/metrics.go

Lines 27 to 34 in 724df91

const (
VUsName = "vus" //nolint:golint
VUsMaxName = "vus_max"
IterationsName = "iterations"
IterationDurationName = "iteration_duration"
DroppedIterationsName = "dropped_iterations"
ErrorsName = "errors"

@mstoykov
Copy link
Contributor Author

mstoykov commented Oct 7, 2021

yes, 🤦 , thanks 🙇

@mstoykov mstoykov merged commit ed18b26 into master Oct 7, 2021
@mstoykov mstoykov deleted the removeErrorsMetric branch October 7, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na-- na-- na-- approved these changes

@inancgumus inancgumus inancgumus approved these changes

@imiric imiric Awaiting requested review from imiric

@yorugac yorugac Awaiting requested review from yorugac

@codebien codebien Awaiting requested review from codebien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @inancgumus @na--