Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to alpine 3.14 #2165

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Upgrade to alpine 3.14 #2165

merged 1 commit into from
Oct 11, 2021

Conversation

nwnt
Copy link
Contributor

@nwnt nwnt commented Oct 8, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #2165 (a1b31eb) into master (42f2e60) will increase coverage by 0.01%.
The diff coverage is 68.42%.

❗ Current head a1b31eb differs from pull request most recent head 4005434. Consider uploading reports for the commit 4005434 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2165      +/-   ##
==========================================
+ Coverage   72.71%   72.73%   +0.01%     
==========================================
  Files         184      184              
  Lines       14571    14577       +6     
==========================================
+ Hits        10596    10603       +7     
+ Misses       3333     3332       -1     
  Partials      642      642              
Flag Coverage Δ
ubuntu 72.69% <68.42%> (+0.04%) ⬆️
windows 72.34% <68.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/login_cloud.go 0.00% <0.00%> (ø)
cmd/login_influxdb.go 0.00% <0.00%> (ø)
cmd/ui.go 20.61% <0.00%> (ø)
lib/metrics/metrics.go 100.00% <ø> (ø)
ui/form_fields.go 45.71% <0.00%> (ø)
output/csv/config.go 74.00% <100.00%> (+4.23%) ⬆️
output/csv/output.go 67.30% <100.00%> (ø)
lib/executor/vu_handle.go 95.32% <0.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed18b26...4005434. Read the comment docs.

Copy link
Contributor

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice, thanks!

@nwnt
Copy link
Contributor Author

nwnt commented Oct 9, 2021

Any trouble with the PR, please let me know :). I will fix it as soon as I can.

@yorugac
Copy link
Contributor

yorugac commented Oct 11, 2021

No thanks, the failing CI is unlikely to be caused by your changes and would require lots of additional research (details are in #1986)
I'll merge this in now 👍

@yorugac yorugac merged commit 4c66e53 into grafana:master Oct 11, 2021
@mstoykov mstoykov added this to the v0.35.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants