Make ChangePathFs compatible with new afero.Fs without updating #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that we won't be using this method I don't think we need to have actual real implementation for it which will require us to update aforo.Fs, so I just returned an error. This is predominantly motivated by the fact that an extension having a dependency on a newer afero.Fs ( through another dependency for example) will not compile as the interface afero.Fs was extended in v1.5.0.
na--
approved these changes
Nov 2, 2021
na--
requested review from
imiric and
codebien
and removed request for
yorugac
codebien
approved these changes
Nov 2, 2021
|
|
, it's obvious this will be a problem sooner or later, even without the specific extension, simply because afero decided to make a breaking change without releasing a new major version... 🤦♂️
|
I tested locally. It works like a charm! Thanks for fixing this ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we won't be using this method I don't think we need to have
actual real implementation for it which will require us to update
aforo.Fs, so I just returned an error.
This is predominantly motivated by the fact that an extension having a
dependency on a newer afero.Fs ( through another dependency for example)
will not compile as the interface afero.Fs was extended in v1.5.0.