tc39: enable async tests #2396
Merged
tc39: enable async tests #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the new failing tests are around classes extending Promises and that not working with the current babel correctly
|
This was done in the goja repo when Promises were added but I for some reason didn't port this at the time 🤦 |
mstoykov
commented
Feb 24, 2022
| @@ -302,6 +305,20 @@ func (ctx *tc39TestCtx) runTC39Test(t testing.TB, name, src string, meta *tc39Me | |||
| if strict { | |||
| src = "'use strict';\n" + src | |||
| } | |||
|
|
|||
| var out []string | |||
| async := meta.hasFlag("async") //nolint:ifshort // false positive | |||
There was a problem hiding this comment.
This is like the second time this linter has had a false positive, and it seems kind of not developed at this point (maybe just vacation for the maintainer).
I also don't remember it having a good case. And arguably in most cases this doesn't make things better IMO.
codebien
approved these changes
Feb 24, 2022
oleiade
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the new failing tests are around classes extending Promises and
that not working with the current babel correctly