Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grpc any.proto marshal error #2523

Merged
merged 8 commits into from
May 18, 2022

Conversation

Flowersea
Copy link
Contributor

Fix grpc any.proto marshal error

Closes #2447

@github-actions github-actions bot requested review from na-- and olegbespalov May 7, 2022 09:01
@na-- na-- requested review from oleiade and removed request for na-- May 7, 2022 15:17
@na-- na-- added this to the v0.39.0 milestone May 7, 2022
@oleiade
Copy link
Member

oleiade commented May 10, 2022

Hi @Flowersea,

Thanks a lot for the contribution 🙇🏻

I'm not too familiar myself with gRPC nor with this specific part of the codebase yet. From what I read in #2447, it seems somewhat possible to reproduce this easily, thus, would it be possible to write unit tests for it without too much hassle involved?

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #2523 (7f823f0) into master (42f2e60) will increase coverage by 2.87%.
The diff coverage is 66.97%.

❗ Current head 7f823f0 differs from pull request most recent head b2d3daa. Consider uploading reports for the commit b2d3daa to get more accurate results

@@            Coverage Diff             @@
##           master    #2523      +/-   ##
==========================================
+ Coverage   72.71%   75.59%   +2.87%     
==========================================
  Files         184      202      +18     
  Lines       14571    15992    +1421     
==========================================
+ Hits        10596    12089    +1493     
+ Misses       3333     3151     -182     
- Partials      642      752     +110     
Flag Coverage Δ
ubuntu 75.39% <66.97%> (+2.74%) ⬆️
windows 75.29% <66.71%> (+2.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/common/context.go 100.00% <ø> (ø)
api/v1/client/client.go 0.00% <0.00%> (ø)
api/v1/client/metrics.go 0.00% <0.00%> (ø)
api/v1/client/status.go 0.00% <0.00%> (ø)
api/v1/group.go 54.05% <ø> (-35.01%) ⬇️
api/v1/metric.go 68.18% <ø> (-31.82%) ⬇️
api/v1/routes.go 55.31% <ø> (ø)
api/v1/status.go 100.00% <ø> (ø)
cmd/login_cloud.go 19.76% <0.00%> (+19.76%) ⬆️
cmd/login_influxdb.go 11.66% <0.00%> (+11.66%) ⬆️
... and 246 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab41a1...b2d3daa. Read the comment docs.

@Flowersea
Copy link
Contributor Author

Flowersea commented May 10, 2022

Hi @Flowersea,

Thanks a lot for the contribution 🙇🏻

I'm not too familiar myself with gRPC nor with this specific part of the codebase yet. From what I read in #2447, it seems somewhat possible to reproduce this easily, thus, would it be possible to write unit tests for it without too much hassle involved?

OK, I will write unit tests later.

@Flowersea Flowersea closed this May 10, 2022
@Flowersea Flowersea reopened this May 10, 2022
@oleiade
Copy link
Member

oleiade commented May 10, 2022

Thanks @Flowersea much appreciated 🙇🏻

Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Flowersea 🙇🏻

Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @Flowersea, thanks for your contribution! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Any.proto for GRPC
5 participants