-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grpc any.proto marshal error #2523
Conversation
Hi @Flowersea, Thanks a lot for the contribution 🙇🏻 I'm not too familiar myself with gRPC nor with this specific part of the codebase yet. From what I read in #2447, it seems somewhat possible to reproduce this easily, thus, would it be possible to write unit tests for it without too much hassle involved? |
Codecov Report
@@ Coverage Diff @@
## master #2523 +/- ##
==========================================
+ Coverage 72.71% 75.59% +2.87%
==========================================
Files 184 202 +18
Lines 14571 15992 +1421
==========================================
+ Hits 10596 12089 +1493
+ Misses 3333 3151 -182
- Partials 642 752 +110
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
OK, I will write unit tests later. |
Thanks @Flowersea much appreciated 🙇🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Flowersea 🙇🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @Flowersea, thanks for your contribution! 🙇
Fix grpc any.proto marshal error
Closes #2447