lib/options: Migrated RunTags to map[string]string type #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
force-pushed
the
runtags-refactor
branch
from
cd37f1e
to
69bb887
Compare
na--
reviewed
Aug 3, 2022
na--
reviewed
Aug 3, 2022
na--
previously approved these changes
Aug 3, 2022
codebien
force-pushed
the
runtags-refactor
branch
from
69bb887
to
853e431
Compare
na--
reviewed
Aug 3, 2022
It facilitates the transition to a more efficient SampleTags.
codebien
force-pushed
the
runtags-refactor
branch
from
853e431
to
3b4c43f
Compare
na--
approved these changes
Aug 3, 2022
mstoykov
approved these changes
Aug 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(edit by @na--) It turns out, this also fixes #2278 😅
It removes the dependency from SampleTags. In this way, it facilitates the transition to a more efficient SampleTags.
Related to: #2594