output/{json,csv}: Metadata migration #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
force-pushed
the
output-metadata
branch
from
195c1d3 to
c8fa900
Compare
|
I just added in the fixups the simplest solution for having this, it requires more refactoring and polishing, I will do them if we will have a consensus. I'm not sure I like this proposal based on adding a fixed naming when we still haven't a consensus on the JS API. |
codebien
force-pushed
the
metrics-metadata
branch
3 times, most recently
from
1ce73e9 to
3c97ec7
Compare
codebien
force-pushed
the
output-metadata
branch
from
c8fa900 to
42db878
Compare
mstoykov
previously approved these changes
Oct 17, 2022
codebien
force-pushed
the
output-metadata
branch
from
42db878 to
2ba0e46
Compare
|
Rebased, I tried to refactor a bit but it touches too many code and it doesn't sound a good idea for v0.41.0. I will keep them for a dedicated PR in v0.42.0 |
mstoykov
approved these changes
Oct 18, 2022
na--
approved these changes
Oct 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It continues the work started in #2654, we decided to split for having a scoped PR and discuss better the implementation details.