Disable async function as group and check callback #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2875 +/- ##
==========================================
- Coverage 76.88% 76.74% -0.15%
==========================================
Files 219 225 +6
Lines 16666 16811 +145
==========================================
+ Hits 12814 12901 +87
- Misses 3044 3083 +39
- Partials 808 827 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The general inconsistencies between group as an idea and asynchronous code makes it not great fit and such we will try to discourage users to mix them. The same is done to check for consistency and as otherwise an async function will always give back true as it returns a promise which is cast to boolean. Updates #2728
mstoykov
force-pushed
the
asyncGroupForbidden
branch
from
fb87f90 to
5b483aa
Compare
mstoykov
changed the title
na--
reviewed
Jan 27, 2023
Co-authored-by: na-- <n@andreev.sh>
na--
reviewed
Jan 27, 2023
na--
reviewed
Jan 31, 2023
na--
previously approved these changes
Jan 31, 2023
codebien
previously approved these changes
Jan 31, 2023
Co-authored-by: na-- <n@andreev.sh>
na--
previously approved these changes
Jan 31, 2023
codebien
previously approved these changes
Jan 31, 2023
na--
approved these changes
Jan 31, 2023
codebien
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general inconsistencies between group as an idea and asynchronous code makes it not great fit and such we will try to discourage users to mix them.
Updates #2728