Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csv time formats #2906

Merged
merged 12 commits into from
Feb 21, 2023
Merged

Csv time formats #2906

merged 12 commits into from
Feb 21, 2023

Conversation

Azanul
Copy link
Contributor

@Azanul Azanul commented Feb 8, 2023 •
edited by imiric
Loading

This PR adds multiple datetime formats other for CSV output format.
Formats to be added:

  • UnixNano
  • RFC3339Nano
  • UnixMilli
  • UnixMicro

Closes #2839

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Azanul Azanul marked this pull request as ready for review February 8, 2023 13:35
imiric
imiric approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🙇 LGTM

We arguably don't need the microsecond precision, but it doesn't hurt to give the option if someone needs it.

@imiric imiric added the documentation-needed A PR which will need a separate PR for documentation label Feb 9, 2023
@imiric imiric added this to the v0.44.0 milestone Feb 9, 2023
codebien
codebien approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @Azanul

@codebien codebien merged commit aab7eae into grafana:master Feb 21, 2023
@na-- na-- mentioned this pull request Apr 12, 2023
Closed
This was referenced Apr 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebien codebien codebien approved these changes

@imiric imiric imiric approved these changes

Assignees
No one assigned
Labels
documentation-needed A PR which will need a separate PR for documentation
Projects
None yet
Milestone
v0.44.0
Development

Successfully merging this pull request may close these issues.

use same timestamp in csv results as in json
4 participants
@Azanul @CLAassistant @imiric @codebien