Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (again) #2940

Merged
merged 6 commits into from
Feb 27, 2023
Merged

Update dependencies (again) #2940

merged 6 commits into from
Feb 27, 2023

Conversation

na--
Copy link
Member

@na-- na-- commented Feb 27, 2023

Decided to make another PR after #2931, because the xk6 tests still had some old golang.org/x/ dependencies, and because the protoreflect library apparently had a pretty major release: https://github.com/jhump/protoreflect/releases/tag/v1.15.0

@na-- na-- added this to the v0.44.0 milestone Feb 27, 2023
@na-- na-- marked this pull request as ready for review February 27, 2023 11:38
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #2940 (33754fb) into master (46d8b29) will decrease coverage by 0.05%.
The diff coverage is 89.47%.

❗ Current head 33754fb differs from pull request most recent head 71aa71a. Consider uploading reports for the commit 71aa71a to get more accurate results

@@            Coverage Diff             @@
##           master    #2940      +/-   ##
==========================================
- Coverage   76.96%   76.92%   -0.05%     
==========================================
  Files         225      225              
  Lines       16893    16907      +14     
==========================================
+ Hits        13001    13005       +4     
- Misses       3061     3070       +9     
- Partials      831      832       +1     
Flag Coverage Δ
ubuntu 76.83% <89.47%> (-0.03%) ⬇️
windows 76.74% <89.47%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/state/state.go 5.71% <0.00%> (-0.35%) ⬇️
cmd/tests/test_state.go 91.83% <ø> (ø)
cmd/common.go 60.00% <60.00%> (ø)
cmd/archive.go 87.50% <100.00%> (+0.26%) ⬆️
cmd/cloud.go 71.58% <100.00%> (+0.15%) ⬆️
cmd/convert.go 68.67% <100.00%> (+0.38%) ⬆️
cmd/login_cloud.go 20.68% <100.00%> (+0.92%) ⬆️
cmd/root.go 81.81% <100.00%> (ø)
cmd/run.go 72.76% <100.00%> (+0.11%) ⬆️
api/v1/metric.go 63.63% <0.00%> (-4.55%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -44,14 +44,15 @@ require (
golang.org/x/term v0.5.0
golang.org/x/time v0.3.0
google.golang.org/grpc v1.53.0
google.golang.org/protobuf v1.28.1
google.golang.org/protobuf v1.28.2-0.20220831092852-f930b1dc76e8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm...this is a not released version. Not optimal, now that we need to use protobuf for other things I hope it will not create issues.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manually update this, it came from the github.com/jhump/protoreflect update, see this 🤷‍♂️

@na-- na-- merged commit 3c25d45 into master Feb 27, 2023
@na-- na-- deleted the update-deps-2 branch February 27, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants