Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xk6-browser to the latest main version #2994

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

na--
Copy link
Member

@na-- na-- commented Mar 31, 2023

We need this to unblock #2960

We need this, so we can refactor some logging code
@codecov-commenter
Copy link

Codecov Report

Merging #2994 (feee15f) into master (d2db852) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head feee15f differs from pull request most recent head 084f4ac. Consider uploading reports for the commit 084f4ac to get more accurate results

@@            Coverage Diff             @@
##           master    #2994      +/-   ##
==========================================
+ Coverage   76.86%   76.91%   +0.05%     
==========================================
  Files         228      228              
  Lines       16988    17018      +30     
==========================================
+ Hits        13057    13089      +32     
+ Misses       3087     3085       -2     
  Partials      844      844              
Flag Coverage Δ
ubuntu 76.91% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/testutils/logrus_hook.go 100.00% <100.00%> (ø)
metrics/engine/engine.go 88.98% <100.00%> (+0.09%) ⬆️
metrics/engine/ingester.go 91.48% <100.00%> (+6.30%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@na-- na-- added this to the v0.44.0 milestone Mar 31, 2023
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @na--, the PR is LGTM. We will release the next version next week. Can we put this PR on hold until then? Or, we can make another PR after this one.

@na--
Copy link
Member Author

na-- commented Mar 31, 2023

@inancgumus , we will make another PR after it. I need to merge this now to unblock my other PRs

Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@na-- na-- merged commit 5c6f679 into master Mar 31, 2023
@na-- na-- deleted the update-xk6-browser branch March 31, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants