Linter and formatting fixes #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2995 +/- ##
==========================================
+ Coverage 76.90% 76.99% +0.08%
==========================================
Files 228 228
Lines 17050 17050
==========================================
+ Hits 13113 13128 +15
+ Misses 3090 3079 -11
+ Partials 847 843 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mstoykov
reviewed
Mar 31, 2023
mstoykov
reviewed
Mar 31, 2023
na--
force-pushed
the
logrus-refactor
branch
2 times, most recently
from
3c2733c
to
f577879
Compare
imiric
previously approved these changes
Mar 31, 2023
imiric
previously approved these changes
Mar 31, 2023
mstoykov
previously approved these changes
Mar 31, 2023
lib/executor/ramping_vus.go
Outdated
| // 3| *************** | ||
| // 2| ***************** | ||
| // 1| ******************* | ||
| // 0------------------------> time(s) |
There was a problem hiding this comment.
Suggested change
| // 0------------------------> time(s) | |
| // 0+-----------------------> time(s) |
Wouldn't that be better 🤔
There was a problem hiding this comment.
not really, it might confuse someone
The only exceptions were some `go generate`d code.
mstoykov
approved these changes
Mar 31, 2023
imiric
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got annoyed by some of the many linter errors we have unresolved. Some of them like the loopclosure ones might even hide other problems, so I decided it's time to fix them.
I'll try to do fixes for various unrelated issues commit by commit. To reduce merge conflicts, this is built on top of #2960.