Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide afero behind fsext package #3025

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Hide afero behind fsext package #3025

merged 1 commit into from
Apr 24, 2023

Conversation

mstoykov
Copy link
Collaborator

This is mostly so that no other part by fsext knows anything about afero.

In the future we can replace the actual implementation.

Updates #1079

This is mostly so that no other part by `fsext` knows anything about
afero.

In the future we can replace the actual implementation.

Updates #1079
@mstoykov mstoykov added this to the v0.45.0 milestone Apr 19, 2023
@github-actions github-actions bot requested review from codebien and na-- April 19, 2023 15:57
@codecov-commenter
Copy link

Codecov Report

Merging #3025 (5ecacfc) into master (d946fdb) will decrease coverage by 0.02%.
The diff coverage is 76.47%.

❗ Current head 5ecacfc differs from pull request most recent head 8b7f619. Consider uploading reports for the commit 8b7f619 to get more accurate results

@@            Coverage Diff             @@
##           master    #3025      +/-   ##
==========================================
- Coverage   77.01%   77.00%   -0.02%     
==========================================
  Files         228      229       +1     
  Lines       17063    17071       +8     
==========================================
+ Hits        13141    13145       +4     
- Misses       3079     3084       +5     
+ Partials      843      842       -1     
Flag Coverage Δ
ubuntu 77.00% <76.47%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/convert.go 68.67% <0.00%> (ø)
cmd/run.go 72.76% <ø> (ø)
cmd/state/state.go 5.71% <0.00%> (ø)
cmd/test_load.go 79.71% <ø> (ø)
js/bundle.go 84.57% <ø> (ø)
js/common/initenv.go 66.66% <0.00%> (ø)
js/runner.go 84.38% <ø> (-0.47%) ⬇️
log/file.go 79.66% <ø> (ø)
cmd/config.go 86.79% <50.00%> (ø)
js/initcontext.go 80.00% <50.00%> (ø)
... and 6 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@na-- na-- requested review from oleiade and removed request for na-- April 20, 2023 07:33
Copy link
Collaborator

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for not including it in the current release and merging it at the beginning of the next cycle.

@mstoykov
Copy link
Collaborator Author

I'm for not including it in the current release and merging it at the beginning of the next cycle.

This is why it is milestoned for 45 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants