Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tc39: enable modules tests #3040

Merged
merged 2 commits into from
Jun 1, 2023
Merged

tc39: enable modules tests #3040

merged 2 commits into from
Jun 1, 2023

Conversation

mstoykov
Copy link
Contributor

A bunch are failing here as there is just no way to be implemented by a transpiler or because they are checking stuff babel doesn't know off.

@mstoykov mstoykov added this to the v0.45.0 milestone Apr 27, 2023
@github-actions github-actions bot requested review from na-- and oleiade April 27, 2023 14:43
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #3040 (7fc4bc2) into master (677bb29) will increase coverage by 0.12%.
The diff coverage is 85.10%.

❗ Current head 7fc4bc2 differs from pull request most recent head fb139a4. Consider uploading reports for the commit fb139a4 to get more accurate results

@@            Coverage Diff             @@
##           master    #3040      +/-   ##
==========================================
+ Coverage   73.54%   73.67%   +0.12%     
==========================================
  Files         239      239              
  Lines       18244    18258      +14     
==========================================
+ Hits        13418    13451      +33     
+ Misses       3956     3938      -18     
+ Partials      870      869       -1     
Flag Coverage Δ
ubuntu 73.67% <85.10%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
output/cloud/expv2/output.go 81.70% <85.10%> (+36.11%) ⬆️

... and 6 files with indirect coverage changes

@mstoykov mstoykov force-pushed the tc39ModulesTests branch 3 times, most recently from 677fd25 to 458521f Compare April 27, 2023 16:48
oleiade
oleiade previously approved these changes Apr 28, 2023
Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 as far as I can tell 😅

@mstoykov mstoykov requested review from olegbespalov and removed request for na-- April 28, 2023 09:23
olegbespalov
olegbespalov previously approved these changes Apr 28, 2023
@mstoykov mstoykov force-pushed the moveModuleResolution branch 2 times, most recently from 51ee021 to 9392a59 Compare May 26, 2023 11:31
Base automatically changed from moveModuleResolution to master May 29, 2023 08:25
A bunch are failing here as there is just no way to be implemented by a
transpiler or because they are checking stuff babel doesn't know off.
olegbespalov
olegbespalov previously approved these changes May 30, 2023
js/tc39/tc39_test.go Outdated Show resolved Hide resolved
@mstoykov mstoykov merged commit 6821c07 into master Jun 1, 2023
@mstoykov mstoykov deleted the tc39ModulesTests branch June 1, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants