Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output/cloud: Versioning #3041

Merged
merged 6 commits into from
May 16, 2023
Merged

output/cloud: Versioning #3041

merged 6 commits into from
May 16, 2023

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Apr 27, 2023

It implements the ability to have multiple cloud versions and it addresses a specific request change #2963 (comment).

@codebien codebien self-assigned this Apr 27, 2023
@codebien codebien requested a review from na-- April 27, 2023 17:08
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #3041 (57af3e3) into master (311d94f) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 57af3e3 differs from pull request most recent head deeadbe. Consider uploading reports for the commit deeadbe to get more accurate results

@@            Coverage Diff             @@
##           master    #3041      +/-   ##
==========================================
+ Coverage   76.70%   76.79%   +0.08%     
==========================================
  Files         230      230              
  Lines       17173    17179       +6     
==========================================
+ Hits        13173    13192      +19     
+ Misses       3150     3140      -10     
+ Partials      850      847       -3     
Flag Coverage Δ
ubuntu 76.79% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cloudapi/config.go 89.47% <100.00%> (+0.34%) ⬆️
output/cloud/output.go 76.55% <100.00%> (+9.65%) ⬆️

@codebien codebien force-pushed the cloud/refactor/versioning branch from 4916184 to 38635ca Compare May 9, 2023 15:42
@codebien codebien changed the base branch from master to cloud/refactor/split-aggregation May 12, 2023 08:42
@codebien codebien force-pushed the cloud/refactor/versioning branch 2 times, most recently from 49eaf9b to 433ad97 Compare May 15, 2023 18:14
@codebien codebien marked this pull request as ready for review May 15, 2023 18:35
output/cloud/output_test.go Outdated Show resolved Hide resolved
output/cloud/output_test.go Show resolved Hide resolved
output/cloud/output_test.go Outdated Show resolved Hide resolved
Base automatically changed from cloud/refactor/split-aggregation to master May 16, 2023 08:42
The output acts now as a gateway starting the required versioned output
based on the new defined Version config option.
@codebien
Copy link
Contributor Author

codebien commented May 16, 2023

@olegbespalov I also added one more test, this should now be ready for a new review. I will squash the fixups before the merge.

na--
na-- previously approved these changes May 16, 2023
@codebien codebien merged commit bc11542 into master May 16, 2023
@codebien codebien deleted the cloud/refactor/versioning branch May 16, 2023 14:51
@codebien codebien added this to the v0.45.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants