Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output/cloudv2: Use unix nano as bucket time #3098

Merged
merged 1 commit into from
May 31, 2023
Merged

output/cloudv2: Use unix nano as bucket time #3098

merged 1 commit into from
May 31, 2023

Conversation

codebien
Copy link
Contributor

A request change from other PRs #3071 (comment)

@codebien codebien self-assigned this May 27, 2023
@github-actions github-actions bot requested review from imiric and mstoykov May 27, 2023 15:38
@codebien codebien mentioned this pull request May 27, 2023
Closed
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (cloud-v2-optimized-sinks@986db71). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1b095d4 differs from pull request most recent head c8e0b43. Consider uploading reports for the commit c8e0b43 to get more accurate results

@@                     Coverage Diff                     @@
##             cloud-v2-optimized-sinks    #3098   +/-   ##
===========================================================
  Coverage                            ?   73.51%           
===========================================================
  Files                               ?      240           
  Lines                               ?    18438           
  Branches                            ?        0           
===========================================================
  Hits                                ?    13555           
  Misses                              ?     4011           
  Partials                            ?      872
Flag Coverage Δ
ubuntu 73.51% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

imiric
imiric previously approved these changes May 29, 2023
View reviewed changes
mstoykov
mstoykov previously approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the linter ;)

@codebien codebien added this to the v0.45.0 milestone May 30, 2023
@codebien codebien force-pushed the cloud-v2-bucket-unix-time branch 2 times, most recently from 7c2ddb0 to c8e0b43 Compare May 30, 2023 15:41
Base automatically changed from cloud-v2-optimized-sinks to master May 31, 2023 08:05
@codebien codebien dismissed stale reviews from mstoykov and imiric via c8e0b43 May 31, 2023 08:05
@mstoykov mstoykov requested a review from imiric May 31, 2023 08:29
@codebien codebien merged commit 25d3da4 into master May 31, 2023
@codebien codebien deleted the cloud-v2-bucket-unix-time branch May 31, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiric imiric imiric approved these changes

@mstoykov mstoykov mstoykov approved these changes

Assignees

@codebien codebien

Labels
None yet
Projects
None yet
Milestone
v0.45.0
Development

Successfully merging this pull request may close these issues.
4 participants
@codebien @codecov-commenter @mstoykov @imiric