output/cloudv2: Flush chunks #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3108 +/- ##
==========================================
+ Coverage 73.74% 73.82% +0.07%
==========================================
Files 241 243 +2
Lines 18460 18474 +14
==========================================
+ Hits 13614 13638 +24
+ Misses 3972 3966 -6
+ Partials 874 870 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Jun 7, 2023
Closed
codebien
force-pushed
the
cloud-v2-flush-chunks
branch
from
b665323
to
bc16911
Compare
mstoykov
reviewed
Jun 8, 2023
Comment on lines
+44
to
+46
| if len(msb.seriesIndex) < f.maxSeriesInSingleBatch { | ||
| continue | ||
| } |
There was a problem hiding this comment.
I was bit weary of an if in this loop ... but to be honest addTimeBucket is so much more complicated that this is likely not an issue.
If it is we can always optimize it.
mstoykov
reviewed
Jun 8, 2023
mstoykov
previously approved these changes
Jun 8, 2023
codebien
force-pushed
the
cloud-v2-flush-chunks
branch
from
bc16911
to
6e63afd
Compare
mstoykov
approved these changes
Jun 8, 2023
imiric
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the number of time series is higher than the maximum batch size than split them in chunks.
Part of #3117