-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the --logformat flag #3389
Conversation
Removed the deprecated --logformat flag, the --log-format alternative should be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to migrate first: https://github.com/search?q=org%3Agrafana%20--logformat&type=code
Given that this is still so widely used it might be worth postponing this a release or three after we remove it everywhere. This isn't really a problem we need to fix, but breaking user experiecne is not great if until yesterday we were telling them to a thing . |
If you use
I value it more visible than the writing we did in the release notes. So, I'm for fixing the other occurrences and removing it in the current version, if someone didn't fix it till now then I wouldn't expect that giving them more versions will make a difference. |
In my opinion, I don't think that we need to postpone this shrug: We need to fix usage, and we have plenty of time. However, I might think that following v0.48 could be one of the biggest from the perspective of breaking changes 😅 |
@olegbespalov the other parts have been changed, we should be now ready to merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What?
Removed the deprecated --logformat flag, the --log-format alternative should be used.
Why?
Deprecation process.