Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js: Return the new deadline error when running code #3399

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

mstoykov
Copy link
Contributor

This was mistakenly broken in 7b5aaaa

@mstoykov mstoykov added this to the v0.48.0 milestone Oct 16, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (43f10a0) 73.12% compared to head (d7aaba4) 73.08%.
Report is 3 commits behind head on master.

❗ Current head d7aaba4 differs from pull request most recent head 7e4a71c. Consider uploading reports for the commit 7e4a71c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3399      +/-   ##
==========================================
- Coverage   73.12%   73.08%   -0.05%     
==========================================
  Files         258      256       -2     
  Lines       19642    19636       -6     
==========================================
- Hits        14363    14350      -13     
- Misses       4397     4399       +2     
- Partials      882      887       +5     
Flag Coverage Δ
ubuntu 73.08% <40.00%> (+0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cloudapi/config.go 90.90% <100.00%> (ø)
js/runner.go 86.42% <50.00%> (+0.67%) ⬆️
js/modules/k6/grpc/client.go 82.74% <0.00%> (-0.64%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit 479099f into master Oct 16, 2023
22 checks passed
@mstoykov mstoykov deleted the fixDeadlineError branch October 16, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants