Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set K6_CLOUD_TRACES_HOST to new hostname #3437

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

Blinkuu
Copy link
Contributor

@Blinkuu Blinkuu commented Nov 2, 2023

What?

This commit updates the default value of K6_CLOUD_TRACES_HOST to target the new endpoint in Grafana clusters.

Why?

This change is done as part of the infrastructure migration efforts. Existing customers are not impacted since insights.k6.io now uses the CNAME record to redirect to the new hostname.

Output from dig:

dig insights.k6.io

; <<>> DiG 9.10.6 <<>> insights.k6.io
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 58234
;; flags: qr rd ra; QUERY: 1, ANSWER: 4, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 512
;; QUESTION SECTION:
;insights.k6.io.			IN	A

;; ANSWER SECTION:
insights.k6.io.		300	IN	CNAME	grpc-k6-api-prod-prod-us-east-0.grafana.net.
grpc-k6-api-prod-prod-us-east-0.grafana.net. 60	IN CNAME k8s-k6apipro-grpcapis-0ed93049b6-2113765632.us-east-2.elb.amazonaws.com.
k8s-k6apipro-grpcapis-0ed93049b6-2113765632.us-east-2.elb.amazonaws.com. 60 IN A 52.15.202.83
k8s-k6apipro-grpcapis-0ed93049b6-2113765632.us-east-2.elb.amazonaws.com. 60 IN A 13.59.222.127

;; Query time: 94 msec
;; SERVER: 2001:730:3ed2:1000::53#53(2001:730:3ed2:1000::53)
;; WHEN: Thu Nov 02 13:26:13 CET 2023
;; MSG SIZE  rcvd: 217

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

This commit updates the default value of `K6_CLOUD_TRACES_HOST` to target the new endpoint in Grafana clusters.
@Blinkuu Blinkuu added the cloud label Nov 2, 2023
@Blinkuu Blinkuu self-assigned this Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ec6519) 73.35% compared to head (faca6f9) 73.33%.

❗ Current head faca6f9 differs from pull request most recent head f98b444. Consider uploading reports for the commit f98b444 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3437      +/-   ##
==========================================
- Coverage   73.35%   73.33%   -0.03%     
==========================================
  Files         259      259              
  Lines       19659    19659              
==========================================
- Hits        14420    14416       -4     
- Misses       4353     4357       +4     
  Partials      886      886              
Flag Coverage Δ
ubuntu 73.27% <100.00%> (-0.02%) ⬇️
windows 73.19% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cloudapi/config.go 83.33% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov
Copy link
Contributor

mstoykov commented Nov 2, 2023

Existing customers are not impacted since insights.k6.io now uses the CNAME record to redirect to the new hostname.

Given that there is a port change how will that help? Or are both ports supported?

@Blinkuu
Copy link
Contributor Author

Blinkuu commented Nov 2, 2023

Existing customers are not impacted since insights.k6.io now uses the CNAME record to redirect to the new hostname.

Given that there is a port change how will that help? Or are both ports supported?

@mstoykov The new load balancer has both 443 and 4443 ports open to remain backwards compatibility. We will close the port once we verify there are no longer any users of the old API, but it's not gonna happen any time soon.

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blinkuu thanks

@codebien codebien merged commit 70c6284 into master Nov 2, 2023
22 checks passed
@codebien codebien deleted the update-traces-host branch November 2, 2023 14:44
@olegbespalov olegbespalov added this to the v0.48.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants