-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set K6_CLOUD_TRACES_HOST
to new hostname
#3437
Conversation
This commit updates the default value of `K6_CLOUD_TRACES_HOST` to target the new endpoint in Grafana clusters.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3437 +/- ##
==========================================
- Coverage 73.35% 73.33% -0.03%
==========================================
Files 259 259
Lines 19659 19659
==========================================
- Hits 14420 14416 -4
- Misses 4353 4357 +4
Partials 886 886
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Given that there is a port change how will that help? Or are both ports supported? |
@mstoykov The new load balancer has both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Blinkuu thanks
What?
This commit updates the default value of
K6_CLOUD_TRACES_HOST
to target the new endpoint in Grafana clusters.Why?
This change is done as part of the infrastructure migration efforts. Existing customers are not impacted since
insights.k6.io
now uses the CNAME record to redirect to the new hostname.Output from
dig
:Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)