-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for overriding grpc authority pseudo header #3454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ali-atac,
it seems a reasonable change as we already discussed in the past.
I see this pull request is in a draft state. However, as it hasn't changed for some days, let me clarify and remind you that signing the CLA is required to be able to merge your contribution.
I encourage you also to discuss before in a dedicated issue your proposal before spending relevant effort on it.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3454 +/- ##
==========================================
- Coverage 73.35% 73.28% -0.08%
==========================================
Files 266 264 -2
Lines 19965 19968 +3
==========================================
- Hits 14646 14633 -13
- Misses 4409 4420 +11
- Partials 910 915 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I would really prefer if we get a test about this. Also this likely will conflict with #3152 |
Thanks for the comment, I'll add some tests next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! |
What?
Why?
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)