Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint fixes #3495

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Lint fixes #3495

merged 5 commits into from
Dec 12, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Dec 7, 2023

What?

Fixing lint issues in packages with 1-5 lint issues

Why?

Cleaning up the code base

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

works on #769

@mstoykov mstoykov added this to the v0.49.0 milestone Dec 7, 2023
cmd/state/state.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (e23ebec) 73.16% compared to head (51739f2) 73.17%.

❗ Current head 51739f2 differs from pull request most recent head 5696308. Consider uploading reports for the commit 5696308 to get more accurate results

Files Patch % Lines
cmd/state/state.go 0.00% 8 Missing ⚠️
cmd/ui.go 0.00% 2 Missing ⚠️
ui/form_fields.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3495   +/-   ##
=======================================
  Coverage   73.16%   73.17%           
=======================================
  Files         267      267           
  Lines       20076    20076           
=======================================
+ Hits        14689    14691    +2     
+ Misses       4471     4469    -2     
  Partials      916      916           
Flag Coverage Δ
ubuntu 73.12% <0.00%> (ø)
windows 73.03% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit 1fe0563 into master Dec 12, 2023
22 checks passed
@mstoykov mstoykov deleted the lintFixes branch December 12, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants