Update to xk6-timers v0.2.2 - fixing ordering of timers #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
commented
Dec 14, 2023
| @@ -94,4 +94,5 @@ require ( | |||
| golang.org/x/text v0.13.0 // indirect | |||
| google.golang.org/genproto/googleapis/api v0.0.0-20230711160842-782d3b101e98 // indirect | |||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20230731193218-e0aa005b6bdf // indirect | |||
| gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect | |||
There was a problem hiding this comment.
Can't figure out why it decided to add with this one in particular :(
mstoykov
force-pushed
the
updateTimers
branch
from
a8e2f69
to
8350c1d
Compare
mstoykov
changed the title
mstoykov
force-pushed
the
updateTimers
branch
from
8350c1d
to
cc224e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3501 +/- ##
==========================================
+ Coverage 72.46% 72.51% +0.04%
==========================================
Files 274 276 +2
Lines 20837 20842 +5
==========================================
+ Hits 15099 15113 +14
+ Misses 4771 4766 -5
+ Partials 967 963 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codebien
approved these changes
Dec 18, 2023
oleiade
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update xk6-timers to include ordering fixes for timers
Why?
Align with the specification
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Related to #3297