Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to xk6-timers v0.2.2 - fixing ordering of timers #3501

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Dec 14, 2023

What?

Update xk6-timers to include ordering fixes for timers

Why?

Align with the specification

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Related to #3297

@mstoykov mstoykov added this to the v0.49.0 milestone Dec 14, 2023
@@ -94,4 +94,5 @@ require (
golang.org/x/text v0.13.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20230711160842-782d3b101e98 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20230731193218-e0aa005b6bdf // indirect
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't figure out why it decided to add with this one in particular :(

@mstoykov mstoykov marked this pull request as draft December 14, 2023 11:51
@mstoykov mstoykov added the dependencies Pull requests that update a dependency file label Dec 15, 2023
@mstoykov mstoykov changed the title Update to xk6-timers v0.2.1 - fixing ordering of timers Update to xk6-timers v0.2.2 - fixing ordering of timers Dec 15, 2023
@mstoykov mstoykov marked this pull request as ready for review December 15, 2023 21:49
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6490bc4) 72.46% compared to head (a05eeb8) 72.51%.

❗ Current head a05eeb8 differs from pull request most recent head cc224e3. Consider uploading reports for the commit cc224e3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3501      +/-   ##
==========================================
+ Coverage   72.46%   72.51%   +0.04%     
==========================================
  Files         274      276       +2     
  Lines       20837    20842       +5     
==========================================
+ Hits        15099    15113      +14     
+ Misses       4771     4766       -5     
+ Partials      967      963       -4     
Flag Coverage Δ
ubuntu 72.45% <ø> (-0.01%) ⬇️
windows 72.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit 05ee905 into master Dec 18, 2023
22 checks passed
@mstoykov mstoykov deleted the updateTimers branch December 18, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants