-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make options.hosts case insensitive #3653
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3653 +/- ##
==========================================
- Coverage 73.58% 73.50% -0.09%
==========================================
Files 277 275 -2
Lines 20244 20242 -2
==========================================
- Hits 14896 14878 -18
- Misses 4400 4410 +10
- Partials 948 954 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Add k6 v0.50.0 release notes * Add changes for the goja refactors in browser * Update release notes/v0.50.0.md Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> * Add browser#1163 to release notes * Add browser#1205 to release notes (#3584) * Add 1215 to release notes * Update release notes/v0.50.0.md Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> * Add screenshot upload to release notes * Update wording for screenshot upload update * Add browser 1209 to release notes (#3604) * Add browser 1217 to release notes (#3603) * Add browser 850 and Go 1.20 PRs to release notes (#3605) * Add browser 1220 and 1221 to release notes * Add/browser 1112 to release notes (#3624) * Add grafana/xk6-browser#1112 * Rephrase browser 1112 to release notes Co-authored-by: Ankur <ankur.agarwal@grafana.com> * Add better error pr for browser evaluate APIs * Add browser testRunId inject prs to release note * Update the verb * Add details of browser#1238 to release notes * Add details of browser#1097 to release notes * Apply suggestions from code review Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> * JWK, options.cloud and some other changelogs * Link webcrypto JWK import/export to PR * Add browser#1241 to release notes * Update the browser#1097 release notes The API has changed so that it requires working with the experimental fs module to upload files from the local file system. * Add browser 986 (#3652) * Add browser 986 * Update add browser 1246 Co-authored-by: Ankur <ankur.agarwal@grafana.com> * Add k6/timers stabilization release notes * Add #3653 to release notes * Apply suggestions from code review Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com> * Add notice for async browser API breaking change * Apply suggestions from code review Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> * Add await explanation on non thenable * Add release changes top-level summary * Apply suggestions from code review Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> * Remove placeholders --------- Co-authored-by: ankur22 <ankur.agarwal@grafana.com> Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com> Co-authored-by: Mihail Stoykov <M.Stoikov@gmail.com> Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com> Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com> Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
What?
It updates the
Hosts
type constructorNewHosts
storesource
keys (i.e. hosts) lowercased, to consider them case insensitive. The internal trie, and theHosts.Match
is already considering them insensitive, as they're treated as lowercase.Why?
Because otherwise,
options.hosts
doesn't work well with non-lowercase hosts.Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
Closes #3651
Also related with #3620