Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend using the globally available timers #3847

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Recommend using the globally available timers #3847

merged 2 commits into from
Jul 17, 2024

Conversation

mstoykov
Copy link
Collaborator

What?

Recommedn just using the globally availabe timers instead of k6/timers

Why?

There is no reason to import them.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.53.0 milestone Jul 15, 2024
@mstoykov mstoykov requested a review from a team as a code owner July 15, 2024 11:35
@mstoykov mstoykov requested review from olegbespalov and joanlopez and removed request for a team July 15, 2024 11:35
joanlopez
joanlopez reviewed Jul 15, 2024
View reviewed changes
js/jsmodules.go Outdated Show resolved Hide resolved
joanlopez
joanlopez reviewed Jul 15, 2024
View reviewed changes
js/jsmodules.go Outdated Show resolved Hide resolved
joanlopez
joanlopez reviewed Jul 15, 2024
View reviewed changes
js/jsmodules.go Outdated Show resolved Hide resolved
olegbespalov
olegbespalov reviewed Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add apart things which @joanlopez mentioned 👍

@mstoykov @joanlopez
Apply suggestions from code review
d4d0874 
Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com>
@mstoykov mstoykov merged commit 111985b into master Jul 17, 2024
23 checks passed
@mstoykov mstoykov deleted the k6TimersUpdate branch July 17, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@joanlopez joanlopez joanlopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.53.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mstoykov @olegbespalov @joanlopez