Deprecate k6/experimental/tracing #3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
added
the
breaking change
mstoykov
requested review from
codebien,
olegbespalov,
Blinkuu and
a team
and removed request for
a team
olegbespalov
previously approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Looks good to me! 👍
It is not related to the PR, but how about creating the "Migration from k6/experimental/tracing" section on https://grafana.com/docs/k6/latest/javascript-api/jslib/http-instrumentation-tempo and giving instructions for migration, even if they just about replacing import path.
codebien
previously approved these changes
Jul 18, 2024
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
olegbespalov
approved these changes
Jul 18, 2024
5 tasks
codebien
approved these changes
Jul 18, 2024
8 tasks
Blinkuu
approved these changes
Jul 18, 2024
mstoykov
added
the
documentation-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Deprecate k6/experimental/tracing.
Why?
The module is now fully available as javacript implementation from https://jslib.k6.io/ and documented here
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Closes #3212