-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add call to AllowMissingFileDescriptors
in lib/netext/grpcext/reflect.go
#3871
Conversation
@codebien @joanlopez any chance you can take a look at this small change? Thank you! |
@olegbespalov @mstoykov any chance someone can take a look at this small change? thank you so much! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 Thanks for your contribution!
8fd47c1
to
ecfe844
Compare
Thanks @olegbespalov - can you help me to get a second review? I also saw what looked like a transient failure in the windows-based codecov github action, but I was not able to re-trigger it. I rebased the branch and pushed, but it did not trigger again. |
@Lordnibbler, it might be some flaky test 😢 So far, I believe all is good 👍 Let's wait for the second reviewer. Luckily, it will be merged after the k6 v0.53 release, which is already formed. |
@olegbespalov thank you! is there anyone else to ping for second review, or are the folks I tagged already sufficient? |
@Lordnibbler, there is no need for pinging; we're aware of it, but as I said, release v0.53 is coming, so that's why the team is busy with other things. No worries, we return to you as soon as possible 😉 |
Thank you! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @olegbespalov said, this is not expected to be included in v0.53. So, if you need it, you have to use the master branch after we merge this pull request.
What?
Add call to
AllowMissingFileDescriptors
inlib/netext/grpcext/reflect.go
.Why?
When this option is enabled, the reflection service will tolerate the absence of certain file descriptors. This means that if a file descriptor is missing, the reflection service will still attempt to provide information about available services and methods, albeit potentially incomplete.
For context as to why we want this fix, we are experiencing similar issues in k6 using grpc server reflection to the issues reported by grpcurl in this issue: fullstorydev/grpcurl#453. We noted after grpcurl 1.9.0 was released with the call to
AllowMissingFileDescriptors
in place the following type of errors were resolved:Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)