Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode #3969

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix dark mode #3969

merged 1 commit into from
Sep 25, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Sep 25, 2024

What?

This change fixes the darkmode of the logo.

To

image

Why?

Currently, it's not readable in dark mode.

image

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Inspired by grafana/k6-studio#219

@olegbespalov olegbespalov self-assigned this Sep 25, 2024
@olegbespalov olegbespalov added this to the v0.54.0 milestone Sep 25, 2024
@olegbespalov olegbespalov marked this pull request as ready for review September 25, 2024 07:21
@olegbespalov olegbespalov requested a review from a team as a code owner September 25, 2024 07:21
@olegbespalov olegbespalov requested review from mstoykov, joanlopez and andrewslotin and removed request for a team September 25, 2024 07:21
Copy link
Contributor

@andrewslotin andrewslotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@olegbespalov olegbespalov merged commit 48fdc05 into master Sep 25, 2024
21 of 22 checks passed
@olegbespalov olegbespalov deleted the chore/dark-mode branch September 25, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants