Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable setup and teardown timeouts #602

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Conversation

na--
Copy link
Member

@na-- na-- commented Apr 25, 2018

This fixes #576, though we should add some upper limits when implementing #539

This fixes #576, though we should add some upper limits when implementing #539
@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #602 into master will increase coverage by 0.04%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   61.99%   62.03%   +0.04%     
==========================================
  Files          97       97              
  Lines        7470     7478       +8     
==========================================
+ Hits         4631     4639       +8     
+ Misses       2587     2585       -2     
- Partials      252      254       +2
Impacted Files Coverage Δ
lib/options.go 98.3% <ø> (ø) ⬆️
cmd/options.go 37.63% <0%> (-0.83%) ⬇️
core/local/local.go 81.09% <100%> (+0.39%) ⬆️
stats/stats.go 39.18% <0%> (ø) ⬆️
js/modules/k6/metrics/metrics.go 75% <0%> (ø) ⬆️
core/engine.go 89.83% <0%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ddf285...409775a. Read the comment docs.

@na-- na-- merged commit beb20d5 into master Apr 26, 2018
@na-- na-- deleted the setup-teardown-timeouts branch April 26, 2018 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make setup setUp timeout configurable via a variable
3 participants