Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .circleci script with go1.11.1 and better coverage #813

Merged
merged 9 commits into from
Oct 17, 2018

Conversation

mstoykov
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 16, 2018

Codecov Report

Merging #813 into master will increase coverage by 6.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
+ Coverage   63.52%   69.86%   +6.34%     
==========================================
  Files         104      111       +7     
  Lines        8529     8679     +150     
==========================================
+ Hits         5418     6064     +646     
+ Misses       2741     2215     -526     
- Partials      370      400      +30
Impacted Files Coverage Δ
js/lib/rice-box.go 100% <0%> (ø)
lib/testutils/httpmultibin.go 95.12% <0%> (ø)
api/v1/client/client.go 0% <0%> (ø)
api/common/context.go 100% <0%> (ø)
api/v1/client/status.go 0% <0%> (ø)
api/v1/client/metrics.go 0% <0%> (ø)
js/lib/lib.go 100% <0%> (ø)
js/modules/k6/html/html.go 85.08% <0%> (+0.8%) ⬆️
js/modules/k6/http/http.go 78.18% <0%> (+3.63%) ⬆️
lib/netext/tracer.go 97.89% <0%> (+4.21%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27646a1...0b5ccc1. Read the comment docs.

@mstoykov mstoykov requested a review from na-- October 16, 2018 12:40
@mstoykov mstoykov changed the title Try to code cover for all packages Update .circleci script with go1.11.1 and better coverage Oct 16, 2018
.circleci/config.yml Outdated Show resolved Hide resolved
@na--
Copy link
Member

na-- commented Oct 17, 2018

btw, it might also be useful to put something like export GOMAXPROCS=N in the test stages, where N is 2 or 4 or something sensible like that. Take a look at this build, the CircleCI machines have quite a few cores, but only 2 of those are accessible to the docker container that the build is running in. And I think that by default, go schedules tests based on the number of cores

@na--
Copy link
Member

na-- commented Oct 17, 2018

Ah, the build error is because the new gihub PR suggestion seems to be one-line only, or at least I don't know how to make multi-line suggestions and I can't find the docs about it...

@na--
Copy link
Member

na-- commented Oct 17, 2018

Ah... FAIL github.com/loadimpact/k6/js 292.870s 🤕
Merge master in the branch?

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstoykov mstoykov merged commit 5788bee into master Oct 17, 2018
@mstoykov mstoykov deleted the fixCodecovCoverage branch October 17, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants