-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .circleci script with go1.11.1 and better coverage #813
Conversation
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
==========================================
+ Coverage 63.52% 69.86% +6.34%
==========================================
Files 104 111 +7
Lines 8529 8679 +150
==========================================
+ Hits 5418 6064 +646
+ Misses 2741 2215 -526
- Partials 370 400 +30
Continue to review full report at Codecov.
|
btw, it might also be useful to put something like |
Ah, the build error is because the new gihub PR suggestion seems to be one-line only, or at least I don't know how to make multi-line suggestions and I can't find the docs about it... |
Ah... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.