Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.23 #846

Merged
merged 4 commits into from
Nov 22, 2018
Merged

Release v0.23 #846

merged 4 commits into from
Nov 22, 2018

Conversation

na--
Copy link
Member

@na-- na-- commented Nov 21, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 21, 2018 •
edited
Loading

Codecov Report

Merging #846 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #846   +/-   ##
=====================================
  Coverage      70%    70%           
=====================================
  Files         111    111           
  Lines        8705   8705           
=====================================
  Hits         6094   6094           
  Misses       2214   2214           
  Partials      397    397
Impacted Files Coverage Δ
cmd/root.go 26.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a081590...bbf89e9. Read the comment docs.

robingustafsson
robingustafsson reviewed Nov 21, 2018
View reviewed changes
Copy link
Member

@robingustafsson robingustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we need to update the CI config to get tag-based builds to work.

.circleci/config.yml Show resolved Hide resolved
mstoykov
mstoykov reviewed Nov 22, 2018
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but add '.0' to the version

cmd/root.go
@@ -36,10 +36,10 @@ import (
"github.com/spf13/cobra"
)

var Version = "0.22.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add .0 at the end

@na-- na-- merged commit 19901f0 into master Nov 22, 2018
@na-- na-- deleted the 0.23-release branch November 22, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robingustafsson robingustafsson robingustafsson approved these changes

@mstoykov mstoykov mstoykov approved these changes

@sniku sniku Awaiting requested review from sniku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@na-- @codecov-io @mstoykov @robingustafsson