Add datadog / statsd integration #893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoreis
force-pushed
the
feature/datadog
branch
from
1ad93af
to
da404b9
Compare
mstoykov
requested changes
Jan 11, 2019
There was a problem hiding this comment.
First, Thank you very much :)
I have only 2 problems that I can find at this time before actually testing it with statsd/datadog:
- I would like the env variables to start with K6 so it is K6_STATSD_ADDR not just STATSD_ADDR just like all the other collectors
- For it to compile - there are some new methods for the Collector interface and some things have changed but as a whole it doesn't look like that many changes
Closed
Merged
|
Superseded by #915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a continuation of #411
ATM, I no longer have access to
uswitchrepo so I've created this new PR.Todo
Update
collector.goandutil.go