Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to set discovery relabel rules for KSM, NE, and WE #802

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

petewall
Copy link
Collaborator

@petewall petewall commented Oct 15, 2024

This change adds extraDiscoveryRules to kube-state-metrics, node exporter, and windows exporter.
Previously, we didn't have those, because we utilized the alloy modules to make the discovery.relabel components, but now we want the ability to set them directly.

KSM, only create the component if the rules are set
NE & WE, add the rule to set instance to be node name as well as add the ability to set the extra rules.

Signed-off-by: Pete Wall <pete.wall@grafana.com>
@petewall petewall requested a review from a team as a code owner October 15, 2024 21:30
@petewall petewall self-assigned this Oct 15, 2024
@petewall petewall merged commit 6951822 into main Oct 16, 2024
20 checks passed
@petewall petewall deleted the feat/extra-discovery-rules branch October 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s-monitoring v2 doesn't allow setting discovery relabeling for node-exporter
2 participants