Add Node Logs feature, which currently only handles journal logs #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pete Wall <pete.wall@grafana.com>
petewall
force-pushed
the
feat/journal-logs
branch
from
100c02d to
8753058
Compare
skl
approved these changes
Nov 26, 2024
| relabel_rules = loki.relabel.journal.rules | ||
| labels = { | ||
| job = {{ .Values.journal.jobLabel | quote }}, | ||
| instance = env("HOSTNAME"), |
There was a problem hiding this comment.
Do you know if the hostname here would generally match the k8s node name?
There was a problem hiding this comment.
I believe it matches the Node name where the Alloy pod lives.
Signed-off-by: Pete Wall <pete.wall@grafana.com>
…, so it ensures that things are still valid there Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
petewall
force-pushed
the
feat/journal-logs
branch
from
785be51 to
75f318d
Compare
Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.