Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Docker Plugin releasing #162

Closed

Conversation

tucksaun
Copy link
Contributor

@tucksaun tucksaun commented Nov 7, 2024

Related to grafana/loki#9247 (review)

Because Docker plugins are built using images but not shipped as images, the pipeline needs to be adjusted to consider this.
See https://docs.docker.com/engine/extend/#developing-a-plugin for more information about Docker plugins.

/cc @trevorwhitney

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@tucksaun
Copy link
Contributor Author

@trevorwhitney you are welcome.

Regarding the failure, I don't think I can do much about it. Let me know if I can be of any assistance

@trevorwhitney
Copy link
Collaborator

@tucksaun yeah, that looks like that's on us. I'll look into it

@trevorwhitney
Copy link
Collaborator

closed in favor of #163, had to be run from origin to get the GH App ID

@tucksaun tucksaun deleted the feat/add-docker-plugin-releasing branch November 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants