add sp nil check

grafana · Jun 21, 2024 · 6f7aea4 · 6f7aea4
1 parent 464ab34
commit 6f7aea4
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/pkg/storage/stores/shipper/bloomshipper/client.go b/pkg/storage/stores/shipper/bloomshipper/client.go
@@ -494,15 +494,16 @@ func newCachedListOpObjectClient(oc client.ObjectClient, ttl, interval time.Dura
 
 func (c *cachedListOpObjectClient) List(ctx context.Context, prefix string, delimiter string) ([]client.StorageObject, []client.StorageCommonPrefix, error) {
 	var (
-		sp       = opentracing.SpanFromContext(ctx)
 		start    = time.Now()
 		cacheDur time.Duration
 	)
 	defer func() {
-		sp.LogKV(
-			"cache_duration", cacheDur,
-			"total_duration", time.Since(start),
-		)
+		if sp := opentracing.SpanFromContext(ctx); sp != nil {
+			sp.LogKV(
+				"cache_duration", cacheDur,
+				"total_duration", time.Since(start),
+			)
+		}
 	}()
 
 	if delimiter != "" {