-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change default values for two GRPC setting we have to set so the quer…
…iers can connect to a frontend or scheduler (#4435) * change gprc server defaults Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com> * add docs and changelog Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>
- Loading branch information
1 parent
81d0f1d
commit 7118dc3
Showing
4 changed files
with
102 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
package loki | ||
|
||
import ( | ||
"bytes" | ||
"flag" | ||
"io" | ||
"strings" | ||
"testing" | ||
"time" | ||
|
||
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func TestFlagDefaults(t *testing.T) { | ||
c := Config{} | ||
|
||
f := flag.NewFlagSet("test", flag.PanicOnError) | ||
c.RegisterFlags(f) | ||
|
||
buf := bytes.Buffer{} | ||
|
||
f.SetOutput(&buf) | ||
f.PrintDefaults() | ||
|
||
const delim = '\n' | ||
|
||
minTimeChecked := false | ||
pingWithoutStreamChecked := false | ||
for { | ||
line, err := buf.ReadString(delim) | ||
if err == io.EOF { | ||
break | ||
} | ||
|
||
require.NoError(t, err) | ||
|
||
if strings.Contains(line, "-server.grpc.keepalive.min-time-between-pings") { | ||
nextLine, err := buf.ReadString(delim) | ||
require.NoError(t, err) | ||
assert.Contains(t, nextLine, "(default 10s)") | ||
minTimeChecked = true | ||
} | ||
|
||
if strings.Contains(line, "-server.grpc.keepalive.ping-without-stream-allowed") { | ||
nextLine, err := buf.ReadString(delim) | ||
require.NoError(t, err) | ||
assert.Contains(t, nextLine, "(default true)") | ||
pingWithoutStreamChecked = true | ||
} | ||
} | ||
|
||
require.True(t, minTimeChecked) | ||
require.True(t, pingWithoutStreamChecked) | ||
|
||
require.Equal(t, true, c.Server.GRPCServerPingWithoutStreamAllowed) | ||
require.Equal(t, 10*time.Second, c.Server.GRPCServerMinTimeBetweenPings) | ||
} |