Separate metas fetch time and blocks fetch time

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
grafana · Mar 26, 2024 · 8e6e781 · 8e6e781
1 parent dbc4f74
commit 8e6e781
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 9 deletions.
diff --git a/pkg/bloomgateway/processor.go b/pkg/bloomgateway/processor.go
@@ -80,7 +80,7 @@ func (p *processor) processTasks(ctx context.Context, tenant string, day config.
 	level.Debug(p.logger).Log("msg", "fetched metas", "count", len(metas), "duration", duration, "err", err)
 
 	for _, t := range tasks {
-		FromContext(t.ctx).AddFetchTime(duration)
+		FromContext(t.ctx).AddMetasFetchTime(duration)
 	}
 
 	if err != nil {
@@ -112,7 +112,7 @@ func (p *processor) processTasks(ctx context.Context, tenant string, day config.
 	level.Debug(p.logger).Log("msg", "fetched blocks", "count", len(refs), "duration", duration, "err", err)
 
 	for _, t := range tasks {
-		FromContext(t.ctx).AddFetchTime(duration)
+		FromContext(t.ctx).AddBlocksFetchTime(duration)
 	}
 
 	if err != nil {

diff --git a/pkg/bloomgateway/stats.go b/pkg/bloomgateway/stats.go
@@ -7,10 +7,10 @@ import (
 )
 
 type Stats struct {
-	Status                                                           string
-	NumTasks, NumFilters                                             int
-	ChunksRequested, ChunksFiltered, SeriesRequested, SeriesFiltered int
-	QueueTime, FetchTime, ProcessingTime, PostProcessingTime         time.Duration
+	Status                                                                         string
+	NumTasks, NumFilters                                                           int
+	ChunksRequested, ChunksFiltered, SeriesRequested, SeriesFiltered               int
+	QueueTime, MetasFetchTime, BlocksFetchTime, ProcessingTime, PostProcessingTime time.Duration
 }
 
 type statsKey int
@@ -49,7 +49,8 @@ func (s *Stats) KVArgs() []any {
 		"chunks_requested", s.ChunksRequested,
 		"chunks_filtered", s.ChunksFiltered,
 		"queue_time", s.QueueTime,
-		"fetch_time", s.FetchTime,
+		"metas_fetch_time", s.MetasFetchTime,
+		"blocks_fetch_time", s.BlocksFetchTime,
 		"processing_time", s.ProcessingTime,
 		"post_processing_time", s.PostProcessingTime,
 	}
@@ -62,11 +63,18 @@ func (s *Stats) AddQueueTime(t time.Duration) {
 	atomic.AddInt64((*int64)(&s.QueueTime), int64(t))
 }
 
-func (s *Stats) AddFetchTime(t time.Duration) {
+func (s *Stats) AddMetasFetchTime(t time.Duration) {
 	if s == nil {
 		return
 	}
-	atomic.AddInt64((*int64)(&s.FetchTime), int64(t))
+	atomic.AddInt64((*int64)(&s.MetasFetchTime), int64(t))
+}
+
+func (s *Stats) AddBlocksFetchTime(t time.Duration) {
+	if s == nil {
+		return
+	}
+	atomic.AddInt64((*int64)(&s.BlocksFetchTime), int64(t))
 }
 
 func (s *Stats) AddProcessingTime(t time.Duration) {