Skip to content

Commit

Permalink
fix(ksonnet): named parameters for containerPort
Browse files Browse the repository at this point in the history
Because ksonnet-lib switched the order of the `containerPort.new()`
parameters from `ksonnet.beta.3` to `ksonnet.beta.4`, we have to use
named parameters to avoid invalid resources when using one of these versions.
  • Loading branch information
sh0rez authored and slim-bean committed Feb 27, 2020
1 parent 8df56ce commit d42859c
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion production/ksonnet/loki-canary/loki-canary.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ k + config {
loki_canary_container::
container.new('loki-canary', $._images.loki_canary) +
$.util.resourcesRequests('10m', '20Mi') +
container.withPorts($.core.v1.containerPort.new('http-metrics', 80)) +
container.withPorts($.core.v1.containerPort.new(name='http-metrics', port=80)) +
container.withArgsMixin($.util.mapToFlags($.loki_canary_args)) +
container.withEnv([
container.envType.fromFieldPath('HOSTNAME', 'spec.nodeName'),
Expand Down
4 changes: 2 additions & 2 deletions production/ksonnet/loki/common.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

defaultPorts::
[
containerPort.newNamed(name='http-metrics', containerPort=80),
containerPort.newNamed(name='grpc', containerPort=9095),
containerPort.new(name='http-metrics', port=containerPort=80),
containerPort.new(name='grpc', port=containerPort=9095),
],
},
}
2 changes: 1 addition & 1 deletion production/ksonnet/loki/gateway.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@

gateway_container::
container.new('nginx', $._images.nginx) +
container.withPorts($.core.v1.containerPort.new('http', 80)) +
container.withPorts($.core.v1.containerPort.new(name='http', port=80)) +
$.util.resourcesRequests('50m', '100Mi'),

local deployment = $.apps.v1.deployment,
Expand Down
2 changes: 1 addition & 1 deletion production/ksonnet/promtail/promtail.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ k + config + scrape_config {

promtail_container::
container.new('promtail', $._images.promtail) +
container.withPorts($.core.v1.containerPort.new('http-metrics', 80)) +
container.withPorts($.core.v1.containerPort.new(name='http-metrics', port=80)) +
container.withArgsMixin($.util.mapToFlags($.promtail_args)) +
container.withEnv([
container.envType.fromFieldPath('HOSTNAME', 'spec.nodeName'),
Expand Down

0 comments on commit d42859c

Please sign in to comment.