Skip to content

Commit

Permalink
fix: Add flags for path & configure kafka for non-memberlist kv store (
Browse files Browse the repository at this point in the history
  • Loading branch information
benclive authored Nov 8, 2024
1 parent b2f3d2e commit f2da621
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/sources/shared/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -1620,6 +1620,8 @@ The `chunk_store_config` block configures how chunks will be cached and how long
Common configuration to be shared between multiple modules. If a more specific configuration is given in other sections, the related configuration within this section will be ignored.

```yaml
# prefix for the path
# CLI flag: -common.path-prefix
[path_prefix: <string> | default = ""]
storage:
Expand Down
1 change: 1 addition & 0 deletions pkg/loki/common/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ func (c *Config) RegisterFlags(f *flag.FlagSet) {

f.StringVar(&c.CompactorAddress, "common.compactor-address", "", "the http address of the compactor in the form http://host:port")
f.StringVar(&c.CompactorGRPCAddress, "common.compactor-grpc-address", "", "the grpc address of the compactor in the form host:port")
f.StringVar(&c.PathPrefix, "common.path-prefix", "", "prefix for the path")
}

type Storage struct {
Expand Down
1 change: 1 addition & 0 deletions pkg/loki/config_wrapper.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ func applyConfigToRings(r, defaults *ConfigWrapper, rc lokiring.RingConfig, merg
r.Ingester.LifecyclerConfig.Zone = rc.InstanceZone
r.Ingester.LifecyclerConfig.ListenPort = rc.ListenPort
r.Ingester.LifecyclerConfig.ObservePeriod = rc.ObservePeriod
r.Ingester.KafkaIngestion.PartitionRingConfig.KVStore = rc.KVStore
}

if mergeWithExisting {
Expand Down

0 comments on commit f2da621

Please sign in to comment.