Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure lambda-promtail to drop labels #10669

Closed
Aanap opened this issue Sep 21, 2023 · 0 comments · Fixed by #10755
Closed

Ability to configure lambda-promtail to drop labels #10669

Aanap opened this issue Sep 21, 2023 · 0 comments · Fixed by #10755
Labels
lambda-promtail type/feature Something new we should do

Comments

@Aanap
Copy link

Aanap commented Sep 21, 2023

Is your feature request related to a problem? Please describe.
Currently we are forwarding logs to Loki from cloudtrail which has a set of default labels, one of which has extremely high cardinality which is affecting ingest into Loki. We want the ability to control which labels get sent to Loki (adding, modifying and dropping).

Describe the solution you'd like
Currently there is the option to add labels through environment variables, equally can we do similar for dropping labels or even better introduce pipelines into Lambda-promtail

Describe alternatives you've considered
Option is to add promtail running on a EC2 in order to use pipelines and hence use the labeldrop feature but this defeats the purpose for using lambda-promtail.

Additional context
Add any other context or screenshots about the feature request here.

@JStickler JStickler added type/feature Something new we should do lambda-promtail labels Sep 27, 2023
MichelHollands added a commit that referenced this issue Oct 13, 2023
**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:
Fixes #10669 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [ ] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](d10549e)

---------

Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
rhnasc pushed a commit to inloco/loki that referenced this issue Apr 12, 2024
**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:
Fixes grafana#10669 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [ ] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@d10549e)

---------

Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lambda-promtail type/feature Something new we should do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants