-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: codec
not initialized in downstream roundtripper
#12873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like part of this PR introduced this bug. Above patch, converted QueryFrontend tripperware into middleware but failed to pass the right `codec` to downstream roundtripper. This PR passes the codec during `InitFrontend` Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
chaudum
approved these changes
May 3, 2024
@rakheshkumbi can you verify this fixes your problem mentioned in #12842? |
kavirajk
changed the title
fix:
fix: May 3, 2024
code
not initialized in downstream roundtrippercodec
not initialized in downstream roundtripper
slim-bean
added
type/bug
Somehing is not working as expected
backport release-3.0.x
labels
May 3, 2024
@kavirajk could you also make sure this gets backported into the 3.0.x branch? |
This PR must be merged before a backport PR will be created. |
Sure @slim-bean |
grafanabot
pushed a commit
that referenced
this pull request
May 3, 2024
7 tasks
shantanualsi
pushed a commit
that referenced
this pull request
May 6, 2024
@kavirajk Tested the fix, it works fine for me. |
This was referenced May 6, 2024
This was referenced May 27, 2024
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Looks like part of this PR introduced this bug. Root cause is
codec
isnil
(never initialized) and panics during downstreamDo
.Above patch, converted QueryFrontend tripperware into middleware but failed to pass the right
codec
to downstream roundtripper.This PR passes the codec during
InitFrontend
.Which issue(s) this PR fixes:
Fixes #12842
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR