Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codec not initialized in downstream roundtripper #12873

Merged
merged 1 commit into from
May 3, 2024

Conversation

kavirajk
Copy link
Contributor

@kavirajk kavirajk commented May 3, 2024

What this PR does / why we need it:
Looks like part of this PR introduced this bug. Root cause is codec is nil (never initialized) and panics during downstream Do.

Above patch, converted QueryFrontend tripperware into middleware but failed to pass the right codec to downstream roundtripper.

This PR passes the codec during InitFrontend.

Which issue(s) this PR fixes:
Fixes #12842

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Looks like part of this PR introduced this bug.

Above patch, converted QueryFrontend tripperware into middleware but failed to pass the right `codec` to downstream roundtripper.

This PR passes the codec during `InitFrontend`

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
@kavirajk kavirajk requested a review from a team as a code owner May 3, 2024 10:15
@kavirajk
Copy link
Contributor Author

kavirajk commented May 3, 2024

@rakheshkumbi can you verify this fixes your problem mentioned in #12842?

@kavirajk kavirajk changed the title fix: code not initialized in downstream roundtripper fix: codec not initialized in downstream roundtripper May 3, 2024
@slim-bean slim-bean added type/bug Somehing is not working as expected backport release-3.0.x labels May 3, 2024
@slim-bean
Copy link
Collaborator

@kavirajk could you also make sure this gets backported into the 3.0.x branch?

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@kavirajk
Copy link
Contributor Author

kavirajk commented May 3, 2024

@kavirajk could you also make sure this gets backported into the 3.0.x branch?

Sure @slim-bean

@kavirajk kavirajk merged commit b6049f6 into main May 3, 2024
62 checks passed
@kavirajk kavirajk deleted the kavirajk/frontend-panic-with-middleware-patch branch May 3, 2024 13:32
grafanabot pushed a commit that referenced this pull request May 3, 2024
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
(cherry picked from commit b6049f6)
shantanualsi pushed a commit that referenced this pull request May 6, 2024
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
@rakheshkumbi
Copy link

@kavirajk Tested the fix, it works fine for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query frontend is getting panic when queried for labels after upgrading to v3.0.0
5 participants