Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [release-3.0.x] fix: codec not initialized in downstream roundtripper #12879

Merged
merged 1 commit into from
May 3, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport b6049f6 from #12873


What this PR does / why we need it:
Looks like part of this PR introduced this bug. Root cause is codec is nil (never initialized) and panics during downstream Do.

Above patch, converted QueryFrontend tripperware into middleware but failed to pass the right codec to downstream roundtripper.

This PR passes the codec during InitFrontend.

Which issue(s) this PR fixes:
Fixes #12842

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
(cherry picked from commit b6049f6)
@grafanabot grafanabot requested a review from a team as a code owner May 3, 2024 13:33
@grafanabot grafanabot added backport size/XS type/bug Somehing is not working as expected labels May 3, 2024
@grafanabot grafanabot requested a review from kavirajk May 3, 2024 13:33
@kavirajk kavirajk merged commit 7300af7 into release-3.0.x May 3, 2024
55 checks passed
@kavirajk kavirajk deleted the backport-12873-to-release-3.0.x branch May 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants