Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lint issues after merge to main #13326

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:
Followup PR for #13308 fixing a lint issue that broke main.

INFO [runner] linters took 28.358598988s with stages: goanalysis_metalinter: 28.013548731s 
integration/bloom_building_test.go:111:14: SA4010: this result of append is never used, except maybe in other appends (staticcheck)
		builders = append(builders, builder)

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts marked this pull request as ready for review June 26, 2024 12:03
@salvacorts salvacorts requested a review from a team as a code owner June 26, 2024 12:03
@salvacorts salvacorts merged commit 7e19cc7 into main Jun 26, 2024
61 checks passed
@salvacorts salvacorts deleted the salvacorts/fix-main-lint branch June 26, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants