refactor(blooms): Do not use sleeps on integration test #13308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvacorts
commented
Jun 25, 2024
|
|
||
| // always cache LIST operations | ||
| c.CacheListOps = true | ||
| f.BoolVar(&c.CacheListOps, prefix+"cache-list-ops", true, "Cache LIST operations. This is a hidden flag.") |
There was a problem hiding this comment.
I'm making this configurable so we can disable it in the integration test.
owen-d
approved these changes
Jun 25, 2024
owen-d
approved these changes
Jun 25, 2024
| // This will always be set to true when flags are registered. | ||
| // In tests, where config is created as literal, it can be set manually. | ||
| CacheListOps bool `yaml:"-"` | ||
| CacheListOps bool `yaml:"cache_list_ops" doc:"hidden"` |
There was a problem hiding this comment.
should give this a yaml:"-" flag too so it can't be loaded that way
salvacorts
deleted the
salvacorts/bloom-refactor/improve-integration-test
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a followup for #13296. We now do not use sleeps to wait for compaction and bloom build to finish. Since we no longer restart the components, we can look at their metrics which will be updated appropriately.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR