Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): Support v3.1.0 in OpenShift dashboards #13430

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Jul 5, 2024

What this PR does / why we need it:
Adds compatibility patches for rendering the Loki dashboards in OpenShift's Console (i.e. rudimentary Grafana 6 dashboard rendering) with v3.1.0 introduced by:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

  • Reverts timeseries to old graph view
  • Removes BloomGateway panels

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

cc @JoaoBraveCoding

@periklis periklis self-assigned this Jul 5, 2024
@periklis periklis requested review from xperimental and a team as code owners July 5, 2024 19:25
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and lgtm from my side

Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

I did not get the index-gateway latency graph to provide values for me, don't yet know why this is the case.

I'm now checking whether there were changes to the metrics that would make us need to update our alerts.

@periklis periklis merged commit 8279d59 into grafana:main Jul 10, 2024
69 checks passed
periklis added a commit to periklis/loki that referenced this pull request Jul 10, 2024
openshift-merge-bot bot added a commit to openshift/loki that referenced this pull request Jul 10, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Jul 11, 2024
periklis added a commit to openshift/loki that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants