-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): Support v3.1.0 in OpenShift dashboards #13430
fix(operator): Support v3.1.0 in OpenShift dashboards #13430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and lgtm from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine 👍
I did not get the index-gateway latency graph to provide values for me, don't yet know why this is the case.
I'm now checking whether there were changes to the metrics that would make us need to update our alerts.
[release-5.9] Backport PR grafana#13430
[release-5.8] Backport PR grafana#13430
What this PR does / why we need it:
Adds compatibility patches for rendering the Loki dashboards in OpenShift's Console (i.e. rudimentary Grafana 6 dashboard rendering) with
v3.1.0
introduced by:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
timeseries
to oldgraph
viewChecklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PRcc @JoaoBraveCoding