-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): add missing loki.storage.azure.chunkDelimiter
parameter to Helm chart
#14011
Conversation
loki.storage.azure.chunkDelimiter
parameter to Helm chartloki.storage.azure.chunkDelimiter
parameter to Helm chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 thanks @NGPixel
@NGPixel could you please fix the CI and bump the version in chart.yaml, add an entry to the changelog, and regenerate the docs. |
@vlad-diachenko It should be fixed now. |
@vlad-diachenko Any updates? |
@NGPixel sorry this fell through the cracks. Any chance you can resolve the conflicts today, I'm happy to shepard it through. |
Thanks @trevorwhitney, I updated the files against the latest version. |
Can @trevorwhitney or @vlad-diachenko merge this PR before anything else comes up? I've had to update the PR 3 times already because the version keeps incrementing. Why is the version numbering not automatically calculated during release (like almost any other software) instead of manually inside the PR itself?? This is wasting a lot of time on the contributors and getting quite ridiculous. |
@NGPixel I agree. We have changed the helm release process to not cut a release and bump the version on every merged PR |
…to Helm chart (grafana#14011) Co-authored-by: Vladyslav Diachenko <82767850+vlad-diachenko@users.noreply.github.com>
What this PR does / why we need it:
The helm chart is missing the
chunk_delimiter
parameter for Azure storage. This PR adds it to the values aschunkDelimiter
.Which issue(s) this PR fixes:
Fixes #14010
Special notes for your reviewer:
N/A
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR